Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTV-1858 | Remove vm preference temporarily #1303

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mnecas
Copy link
Member

@mnecas mnecas commented Jan 14, 2025

Issue:
With older version of the Kubevirt migrating specific windows version the preference always sets BIOS and if we set the UEFI the creation fails.

Quick fix:
Remove the preference usage.

ref: MTV-1858 CNV-49381

@mnecas mnecas requested a review from yaacov as a code owner January 14, 2025 14:32
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 15.45%. Comparing base (3113e86) to head (9441f55).

Files with missing lines Patch % Lines
pkg/controller/plan/kubevirt.go 0.00% 10 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1303      +/-   ##
==========================================
- Coverage   15.50%   15.45%   -0.05%     
==========================================
  Files         112      112              
  Lines       23377    23375       -2     
==========================================
- Hits         3624     3613      -11     
- Misses      19466    19477      +11     
+ Partials      287      285       -2     
Flag Coverage Δ
unittests 15.45% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yaacov
Copy link
Member

yaacov commented Jan 14, 2025

this fix is until CNV-49381 is fixed on CNV side ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants