MTV-1744 | Allow dots in the VM names #1281
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: Right now we are not allowing to keep the VM names which have the dots in the name but we replace the dots with dashes. Fix: Use the IsDNS1123Subdomain validation instead of IsDNS1123Label and ignore the dots in the replacemnet of the new name. Signed-off-by: Martin Necas <[email protected]>
|
yaacov
reviewed
Dec 19, 2024
| @@ -33,7 +33,7 @@ func (r *KubeVirt) changeVmNameDNS1123(vmName string, vmNamespace string) (gener | |||
|
|
|||
| // changes VM name to match DNS1123 RFC convention. | |||
| func changeVmName(currName string) string { | |||
| var underscoreExcluded = regexp.MustCompile("[_.]") | |||
| var underscoreExcluded = regexp.MustCompile("[_]") | |||
There was a problem hiding this comment.
we also need to replace or remove "." if it is in the start or end of the name
https://github.com/kubernetes/apimachinery/blob/master/pkg/util/validation/validation.go#L206
There was a problem hiding this comment.
remove the "." if they are in the start of end ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Right now we are not allowing to keep the VM names which have the dots in the name but we replace the dots with dashes.
Fix:
Use the IsDNS1123Subdomain validation instead of IsDNS1123Label and ignore the dots in the replacemnet of the new name.
Ref:
https://issues.redhat.com/browse/MTV-1744