Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TKC-3004): kill nested processes on timeout properly #6097

Merged
merged 3 commits into from
Dec 20, 2024
Merged

fix(TKC-3004): kill nested processes on timeout properly #6097

merged 3 commits into from
Dec 20, 2024

Conversation

rangoo94
Copy link
Member

@rangoo94 rangoo94 commented Dec 20, 2024 •
edited
Loading

Pull request description

  • Kill nested processes correctly
  • Set properly Test Workflow Execution status when step timeout happens
  • Make step timeout graceful - allow retries and continuing

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Fixes

@rangoo94 rangoo94 requested a review from a team as a code owner December 20, 2024 10:09
@rangoo94 rangoo94 merged commit 0c731a9 into main Dec 20, 2024
10 checks passed
@rangoo94 rangoo94 deleted the dawid/TKC-3004-fix-timeout branch December 20, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsukhin vsukhin vsukhin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rangoo94 @vsukhin