Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TKC-2188): use global.defaultRegistry for Test Workflows #5644

Merged
merged 4 commits into from
Jul 8, 2024
Merged

fix(TKC-2188): use global.defaultRegistry for Test Workflows #5644

merged 4 commits into from
Jul 8, 2024

Conversation

rangoo94
Copy link
Member

@rangoo94 rangoo94 commented Jul 8, 2024

Pull request description

  • Pass the Default Registry down to parallel and services steps
  • Change the image in the container spec to include the Default Registry if none provided
  • Store/Get image details from the Cache based on the Default Registry if needed

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Fixes

@rangoo94 rangoo94 requested a review from a team as a code owner July 8, 2024 13:15
@netlify Netlify
Copy link

netlify bot commented Jul 8, 2024 •
edited
Loading

✅ Deploy Preview for testkube-docs-preview canceled.

Name Link
🔨 Latest commit ca1538f
🔍 Latest deploy log https://app.netlify.com/sites/testkube-docs-preview/deploys/668be7d17545960009ca7b4e

@rangoo94 rangoo94 merged commit 483b907 into develop Jul 8, 2024
11 checks passed
@rangoo94 rangoo94 deleted the dawid/fix/use-global-registry-for-parallel-and-services branch July 8, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsukhin vsukhin vsukhin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rangoo94 @vsukhin