Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: TKC-1290: add support for custom CA certificates (#5098) #5135

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

dejanzele
Copy link
Contributor

  • TKC-1290: add support for custom CA certificates

  • TKC-1290: fix failing unit tests for custom CA certificates

Pull request description

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

Fixes

* TKC-1290: add support for custom CA certificates

* TKC-1290: fix failing unit tests for custom CA certificates
Copy link

netlify bot commented Mar 11, 2024

Deploy Preview for testkube-docs-preview canceled.

Name Link
🔨 Latest commit 1f4cd38
🔍 Latest deploy log https://app.netlify.com/sites/testkube-docs-preview/deploys/65f017931764c100089c43fd

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 8.10811% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 26.79%. Comparing base (27543bb) to head (38a1262).

Files Patch % Lines
pkg/agent/agent.go 5.71% 30 Missing and 3 partials ⚠️
pkg/scheduler/service.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5135      +/-   ##
==========================================
- Coverage   26.86%   26.79%   -0.08%     
==========================================
  Files         281      281              
  Lines       25279    25313      +34     
==========================================
- Hits         6791     6782       -9     
- Misses      17795    17834      +39     
- Partials      693      697       +4     
Flag Coverage Δ
integrationtests 6.65% <0.00%> (-0.01%) ⬇️
unittests 22.17% <8.10%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dejanzele dejanzele merged commit 3771c53 into main Mar 12, 2024
11 checks passed
@dejanzele dejanzele deleted the cherry-pick/agent-custom-ca branch March 12, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants