fix(TKC-3004): kill nested processes on timeout properly

cmd/testworkflow-init/orchestration/processes.go

@@ -35,21 +35,14 @@ func (p *processNode) Find(pid int32) []*processNode {
 }
 
 func (p *processNode) VirtualizePath(pid int32) {
-	path := p.Find(pid)
-	if path == nil {
-		return
-	}
-
-	// Cannot virtualize itself
-	if len(path) == 1 {
-		return
-	}
-
-	// Virtualize recursively
-	for i := 1; i < len(path); i++ {
-		delete(path[0].nodes, path[i])
-		for node := range path[i].nodes {
-			path[0].nodes[node] = struct{}{}
+	for ps := range p.nodes {
+		if ps.pid == pid {
+			for sub := range ps.nodes {
+				p.nodes[sub] = struct{}{}
+			}
+			delete(p.nodes, ps)
+		} else {
+			ps.VirtualizePath(pid)
 		}
 	}
 }
@@ -106,7 +99,10 @@ func (p *processNode) Resume() error {
 func (p *processNode) Kill() error {
 	errs := make([]error, 0)
 	if p.pid != -1 {
-		return errors.Wrap((&gopsutil.Process{Pid: p.pid}).Kill(), "killing processes")
+		err := errors.Wrap((&gopsutil.Process{Pid: p.pid}).Kill(), "killing processes")
+		if err != nil {
+			return err
+		}
 	}
 	for node := range p.nodes {
 		err := node.Kill()