Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't reset executionRequest while changing description #966

Merged
merged 1 commit into from
Dec 4, 2023
Merged

fix: don't reset executionRequest while changing description #966

merged 1 commit into from
Dec 4, 2023

Conversation

rangoo94
Copy link
Member

@rangoo94 rangoo94 commented Dec 4, 2023

Changes

  • don't reset executionRequest while changing description

Fixes

How to test it

  • Add variables to some Test
  • Modify the Test description
  • Go back to variables
  • The variables are still the same (prior this fix: the variables has been removed)

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@vercel Vercel
Copy link

vercel bot commented Dec 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
testkube-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2023 9:32am

@rangoo94 rangoo94 merged commit fcedaf5 into develop Dec 4, 2023
9 checks passed
@rangoo94 rangoo94 deleted the dawid/fix/updating-test-description branch December 4, 2023 09:34
@github-actions github-actions bot mentioned this pull request Dec 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topliceanurazvan topliceanurazvan topliceanurazvan approved these changes

@exu exu Awaiting requested review from exu exu is a code owner

@pavloburchak pavloburchak Awaiting requested review from pavloburchak

@haneabogdan haneabogdan Awaiting requested review from haneabogdan haneabogdan is a code owner

@devcatalin devcatalin Awaiting requested review from devcatalin devcatalin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rangoo94 @topliceanurazvan