Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename EntityListContent to EntityView #959

Merged
merged 35 commits into from
Dec 15, 2023
Merged

refactor: rename EntityListContent to EntityView #959

merged 35 commits into from
Dec 15, 2023

Conversation

topliceanurazvan
Copy link
Member

@topliceanurazvan topliceanurazvan commented Nov 23, 2023 •
edited
Loading

Changes

  • Rename EntityListContent to EntityView as we will support both grid and table views for tests/test suites
  • Add slots for the entity view component and also for the switch

Fixes

How to test it

screenshots

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@vercel Vercel
Copy link

vercel bot commented Nov 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
testkube-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 15, 2023 3:03pm

@topliceanurazvan topliceanurazvan marked this pull request as draft November 24, 2023 14:39
@topliceanurazvan topliceanurazvan marked this pull request as ready for review November 27, 2023 07:48
@topliceanurazvan topliceanurazvan marked this pull request as draft November 27, 2023 13:07
@rangoo94
Copy link
Member

Something is wrong with "Status" size on preview:

Zrzut ekranu 2023-12-14 o 13 32 07

rangoo94
rangoo94 reviewed Dec 14, 2023
View reviewed changes
Copy link
Member

@rangoo94 rangoo94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except:

  • one bug with displaying status filter
  • I don't think it's necessary to have Test*MetricsLayer and Test*MetricsContext (maybe just simplified useTestMetrics = (name) => useTestMetricsQuery(/* ... */) helper is what we want?)

packages/web/src/components/atoms/EntityDropdown/EntityDropdown.tsx Outdated Show resolved Hide resolved
packages/web/src/components/atoms/EntityDropdown/EntityDropdown.tsx Outdated Show resolved Hide resolved
packages/web/src/components/organisms/EntityView/EntityView.tsx Outdated Show resolved Hide resolved
packages/web/src/components/organisms/EntityView/EntityViewFilters/EntityViewFilters.tsx Outdated Show resolved Hide resolved
...ages/web/src/components/organisms/EntityView/EntityViewFilters/StatusFilter/StatusFilter.tsx Show resolved Hide resolved
...ages/web/src/components/pages/TestSuites/TestSuitesList/metrics/TestSuitesMetricsContext.tsx Outdated Show resolved Hide resolved
...ages/web/src/components/pages/TestSuites/TestSuitesList/metrics/TestSuitesMetricsContext.tsx Outdated Show resolved Hide resolved
packages/web/src/plugins/tests-and-test-suites/plugin.tsx Outdated Show resolved Hide resolved
packages/web/src/plugins/tests-and-test-suites/plugin.tsx Outdated Show resolved Hide resolved
packages/web/src/components/pages/Tests/TestsList/metrics/TestsMetricsContext.tsx Outdated Show resolved Hide resolved
rangoo94
rangoo94 reviewed Dec 15, 2023
View reviewed changes
Copy link
Member

@rangoo94 rangoo94 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last minor issues (most importantly ?? []) and will LGTM 👍

packages/web/src/components/molecules/EntityGrid/EntityGridItemPure.tsx Outdated Show resolved Hide resolved
packages/web/src/components/molecules/TestActionsDropdown/TestActionsDropdown.tsx Outdated Show resolved Hide resolved
packages/web/src/components/molecules/TestActionsDropdown/TestActionsDropdown.tsx Show resolved Hide resolved
packages/web/src/components/molecules/TestSuiteActionsDropdown/TestSuiteActionsDropdown.tsx Outdated Show resolved Hide resolved
packages/web/src/components/molecules/EntityGrid/EntityGridItemPure.tsx Outdated Show resolved Hide resolved
packages/web/src/components/pages/Tests/TestsList/TestsList.tsx Outdated Show resolved Hide resolved
packages/web/src/models/actionsDropdown.ts Outdated Show resolved Hide resolved
packages/web/src/models/test.ts Outdated Show resolved Hide resolved
packages/web/src/styles/globalStyles.ts Outdated Show resolved Hide resolved
packages/web/src/components/pages/TestSuites/TestSuitesList/TestSuitesList.tsx Outdated Show resolved Hide resolved
rangoo94
rangoo94 approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@rangoo94 rangoo94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One trivial issue (left unused empty component/directory), besides LGTM 👍

packages/web/src/components/pages/Tests/TestsTable/TestsTable.tsx Outdated Show resolved Hide resolved
@topliceanurazvan topliceanurazvan merged commit df55203 into develop Dec 15, 2023
9 of 13 checks passed
@topliceanurazvan topliceanurazvan deleted the razvantopliceanu/refactor/entity-view branch December 15, 2023 15:44
@github-actions github-actions bot mentioned this pull request Jan 23, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rangoo94 rangoo94 rangoo94 approved these changes

@exu exu Awaiting requested review from exu exu is a code owner

@haneabogdan haneabogdan Awaiting requested review from haneabogdan haneabogdan is a code owner

@devcatalin devcatalin Awaiting requested review from devcatalin devcatalin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@topliceanurazvan @rangoo94 @haneabogdan