fix: executors e2e tests #913
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mortada-codes
changed the title
| @@ -10,4 +10,8 @@ export class ExecutorsPage { | |||
| public async openCreateExecutorDialog(): Promise<void> { | |||
| await this.page.click('xpath=//button//span[contains(text(),"Create a new executor")]'); // TODO: data-test | |||
| } | |||
|
|
|||
| public async openExecutorSettings(executorName: string): Promise<void> { | |||
| await this.page.click(`xpath=//div/span[text()="${executorName}"]`); | |||
| @@ -39,9 +40,55 @@ test(`Create custom container executor`, async ({page}) => { | |||
| await api.removeExecutor(realExecutorName); | |||
| }); | |||
|
|
|||
| test.skip(`Custom container executor - general settings`, async ({page}) => {}); | |||
| test(`Custom container executor - general settings`, async ({page}) => { | |||
There was a problem hiding this comment.
I think this case can be extended with setting custom command, and argument
| await executorsPage.openExecutorSettings(realExecutorName); | ||
|
|
||
| const executorGeneralSettingsPage = new ExecutorGeneralSettingsPage(page); | ||
| const executorNameInput = await executorGeneralSettingsPage.getExecutorName(); |
There was a problem hiding this comment.
Usually it's better to user "validators" instead of getting and then comparing the value.
The difference is in this case it's waiting for element matching the selector (input[id="general-settings-name-type_name"]), then getting it's value, and then comparing (expect assertion). Element will be checked once, so any state transitions can make the test unstable.
In case of validators it would be looking for the same element, but with specific text value.
So, executorGeneralSettingsPage.validateExecutorName(executorName):
and, all that's needed is checking if the element exists:
this.page.locator(`xpath=//input[@id="general-settings-name-type_name" and text="${executorName}"]`)
Additionally, on the test level I would use higher-level function instead - like executorGeneralSettingsPage.validateExecutorDetails that would then contain validateExecutorName on the Page level. The main goal is to keep tests high-level, and keep all of the details on the lower (Page) level.
mortada-codes
requested review from
exu,
pavloburchak,
rangoo94 and
haneabogdan
as code owners
This PR...
Changes
Fixes
How to test it
screenshots
Checklist