Allow synchronization with explicit project slug #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3c3f400 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
f1ames
force-pushed
the
f1ames/feat/synchronize-explicit-project
branch
from
4810cb0 to
3c3f400
Compare
4 tasks
WitoDelnat
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends synchronizer synchronization API to allow passing project slug with path / repo data. This is useful for scenarios where integration already has project slug (e.g. it was passed by user/developer). It also reduces API requests and permissions issue (e.g. when using Automation Token,
getUserquery is not allowed and it was used to fetch project slug for repo data).Needed for https://github.com/kubeshop/monokle-saas/issues/2037.
Changes
Fixes
Checklist