Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update imagePullSecrets #978

Merged
merged 1 commit into from
Jan 15, 2025
Merged

feat: update imagePullSecrets #978

merged 1 commit into from
Jan 15, 2025

Conversation

ypoplavs
Copy link
Contributor

@ypoplavs ypoplavs commented Jan 15, 2025 •
edited
Loading

Pull request description

Add an option to accept different data types for imagePullSecrets:

global:
  imagePullSecrets: 
  - name: secret1
  - name: secret2

global:
  imagePullSecrets: 
  - secret1
  - secret2

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

Fixes

@ypoplavs ypoplavs requested a review from a team as a code owner January 15, 2025 10:37
@ypoplavs ypoplavs merged commit 3bddb9c into main Jan 15, 2025
3 of 4 checks passed
@ypoplavs ypoplavs deleted the TKC-3104/update-imagepullsecrets-to-accept-different-data-types branch January 15, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ed382 ed382 ed382 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ypoplavs @ed382