Merge pull request #954 from kubeshop/improve-startup-time

chore: improve startup time
kubeshop · Oct 28, 2024 · d387888 · d387888
2 parents d78c0a3 + 2da9f50
commit d387888
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 20 deletions.
diff --git a/charts/testkube-api/templates/deployment.yaml b/charts/testkube-api/templates/deployment.yaml
@@ -228,14 +228,22 @@ spec:
             - name: grpc
               containerPort: 8089
               protocol: TCP
-          livenessProbe:
-            initialDelaySeconds: {{ .Values.livenessProbe.initialDelaySeconds }}
+          startupProbe:
+            initialDelaySeconds: 3
+            periodSeconds: 3
+            timeoutSeconds: 3
+            failureThreshold: 20
             httpGet:
               path: /health
               port: {{ .Values.service.port }}
               scheme: HTTP
           readinessProbe:
-            initialDelaySeconds: {{ .Values.readinessProbe.initialDelaySeconds }}
+            httpGet:
+              path: /health
+              port: {{ .Values.service.port }}
+              scheme: HTTP
+          livenessProbe:
+            initialDelaySeconds: {{ .Values.livenessProbe.initialDelaySeconds }}
             httpGet:
               path: /health
               port: {{ .Values.service.port }}

diff --git a/charts/testkube-api/values.yaml b/charts/testkube-api/values.yaml
@@ -675,10 +675,6 @@ testConnection:
 livenessProbe:
   initialDelaySeconds: 30
 
-## Testkube API Readiness probe
-readinessProbe:
-  initialDelaySeconds: 45
-
 ## Testkube API HTTP body size limit
 ## httpBodyLimit: 1073741824
 

diff --git a/charts/testkube/values-demo.yaml b/charts/testkube/values-demo.yaml
@@ -332,8 +332,6 @@ testkube-api:
       scheme: HTTP
     ## Amount of request failures before the container receives a terminate signal
     failureThreshold: 3
-    ## Time to wait after the initial deployment before performing first probe
-    initialDelaySeconds: 60
     ## How often (in seconds) to perform the probes. This value sends one probe every 30 seconds
     periodSeconds: 30
     ## Minimum consecutive successes for the probe to be considered successful after having failed

diff --git a/charts/testkube/values-develop.yaml b/charts/testkube/values-develop.yaml
@@ -261,7 +261,7 @@ testkube-api:
     ## Amount of request failures before the container receives a terminate signal
     failureThreshold: 3
     ## Time to wait after the initial deployment before performing first probe
-    initialDelaySeconds: 180
+    initialDelaySeconds: 60
     ## How often (in seconds) to perform the probes. This value sends one probe every 30 seconds
     periodSeconds: 30
     ## Minimum consecutive successes for the probe to be considered successful after having failed
@@ -278,8 +278,6 @@ testkube-api:
       scheme: HTTP
     ## Amount of request failures before the container receives a terminate signal
     failureThreshold: 3
-    ## Time to wait after the initial deployment before performing first probe
-    initialDelaySeconds: 60
     ## How often (in seconds) to perform the probes. This value sends one probe every 30 seconds
     periodSeconds: 30
     ## Minimum consecutive successes for the probe to be considered successful after having failed

diff --git a/charts/testkube/values-stage.yaml b/charts/testkube/values-stage.yaml
@@ -276,8 +276,6 @@ testkube-api:
       scheme: HTTP
     ## Amount of request failures before the container receives a terminate signal
     failureThreshold: 3
-    ## Time to wait after the initial deployment before performing first probe
-    initialDelaySeconds: 60
     ## How often (in seconds) to perform the probes. This value sends one probe every 30 seconds
     periodSeconds: 30
     ## Minimum consecutive successes for the probe to be considered successful after having failed

diff --git a/charts/testkube/values.yaml b/charts/testkube/values.yaml
@@ -605,8 +605,7 @@ testkube-api:
       - testkube.example.com
     tlsenabled: false
     # -- Placing a host in the TLS config will indicate a certificate should be created
-    tls:
-      []
+    tls: []
     # - hosts:
     #     - testkube.example.com
     #   secretName: testkube-cert-secret
@@ -752,10 +751,6 @@ testkube-api:
   livenessProbe:
     # -- Initial delay for liveness probe
     initialDelaySeconds: 15
-  # -- Testkube API Readiness probe parameters
-  readinessProbe:
-    # -- Initial delay for readiness probe
-    initialDelaySeconds: 30
 
   # -- Enable analytics for Testkube
   analyticsEnabled: true