fix: use list for parameters

Signed-off-by: Vladislav Sukhin <[email protected]>
kubeshop · Jan 16, 2025 · cbd148f · cbd148f
1 parent 9e4a670
commit cbd148f
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 6 deletions.
diff --git a/charts/testkube-operator/templates/executor.testkube.io_webhooks.yaml b/charts/testkube-operator/templates/executor.testkube.io_webhooks.yaml
@@ -112,27 +112,33 @@ spec:
                   Deprecated: field is not used
                 type: boolean
               parameters:
-                additionalProperties:
+                description: webhook parameters
+                items:
                   description: webhook parameter schema
                   properties:
                     default:
                       description: default parameter value
                       type: string
                     description:
-                      description: description for the property
+                      description: description for the parameter
                       type: string
                     example:
                       description: example value for the parameter
                       type: string
+                    name:
+                      description: unique parameter name
+                      type: string
                     pattern:
                       description: regular expression to match
                       type: string
                     required:
                       description: whether parameter is required
                       type: boolean
                   type: object
+                  required:
+                  - name
                 description: webhook parameters
-                type: object
+                type: array
               payloadObjectField:
                 description: will load the generated payload for notification inside
                   the object

diff --git a/charts/testkube-operator/templates/executor.testkube.io_webhooktemplates.yaml b/charts/testkube-operator/templates/executor.testkube.io_webhooktemplates.yaml
@@ -113,27 +113,33 @@ spec:
                 description: webhook headers (golang template supported)
                 type: object
               parameters:
-                additionalProperties:
+                description: webhook parameters
+                items:
                   description: webhook parameter schema
                   properties:
                     default:
                       description: default parameter value
                       type: string
                     description:
-                      description: description for the property
+                      description: description for the parameter
                       type: string
                     example:
                       description: example value for the parameter
                       type: string
+                    name:
+                      description: unique parameter name
+                      type: string
                     pattern:
                       description: regular expression to match
                       type: string
                     required:
                       description: whether parameter is required
                       type: boolean
                   type: object
+                  required:
+                  - name
                 description: webhook parameters
-                type: object
+                type: array
               payloadObjectField:
                 description: will load the generated payload for notification inside
                   the object