update controller runtime to v0.15 #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranakan19
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
mfrancisc,
drpaneas,
metlos and
fbm3307
as code owners
alexeykazakov
approved these changes
Oct 15, 2024
ranakan19
commented
Nov 12, 2024
| require.ErrorContains(t, err, "dial tcp: lookup fail-cluster.com") | ||
| // for ci the error message is dial tcp: lookup fail-cluster.com on 127.0.0.53:53: no such host, could go the regex way or string submatching with wildcards | ||
| // having two separate checks for different substrings is an easy fix | ||
| require.ErrorContains(t, err, "no such host") |
There was a problem hiding this comment.
I did consider only checking for "no such host", but I do see value in checking for the host name as well - which we are setting explicitly in the test above.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #86 +/- ##
=======================================
Coverage 68.00% 68.00%
=======================================
Files 44 44
Lines 3175 3175
=======================================
Hits 2159 2159
Misses 825 825
Partials 191 191
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates k8s dependencies to 0.28 and controller-runtime to v0.15.
All the other PRs update k8s dependencies to 0.27 but this one updates to 0.28 because of the following error:
../../../../pkg/mod/k8s.io/[email protected]/pkg/describe/describe.go:2667:65: cannot use ing.Status.LoadBalancer (variable of type "k8s.io/api/networking/v1".IngressLoadBalancerStatus) as "k8s.io/api/core/v1".LoadBalancerStatus value in argument to loadBalancerStatusStringerand kubectl 0.28 was the only comptabile version.
With the update to controller-runtime v0.15 (changes in release detailed here), this PR has following changes to combat the breaking changes:
Changes wrt - https://issues.redhat.com/browse/SANDBOX-675
DO NOT MERGE (All the PRs related to version updates need to be merged at once, but these PR are for early feedback so that there are not a lot of changes to review at once)