Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SANDBOX-683: add ban reason #74

Merged
merged 6 commits into from
Sep 11, 2024
Merged

Conversation

rsoaresd
Copy link
Contributor

@rsoaresd rsoaresd commented Sep 10, 2024

Description

  • add ban reason when banning a user

Associated PRs:

codeready-toolchain/toolchain-common#427

Issue ticket number and link

SANDBOX-681

Copy link
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Great Job 🚀 🏅

Copy link
Contributor

@fbm3307 fbm3307 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, great work,
just few minor comments

README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
Copy link
Contributor

@MatousJobanek MatousJobanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but address @fbm3307's suggestions please

@rsoaresd rsoaresd requested a review from fbm3307 September 11, 2024 08:49
Copy link
Contributor

@fbm3307 fbm3307 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing my comments.

@rsoaresd rsoaresd merged commit b4446e5 into kubesaw:master Sep 11, 2024
8 checks passed
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.62%. Comparing base (53a2210) to head (bcd9aca).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   69.61%   69.62%   +0.01%     
==========================================
  Files          43       43              
  Lines        2564     2565       +1     
==========================================
+ Hits         1785     1786       +1     
  Misses        588      588              
  Partials      191      191              
Files with missing lines Coverage Δ
pkg/cmd/ban.go 74.07% <100.00%> (+0.48%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants