Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install az & aws clis in the kubekins e2e image #33225

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

install az & aws clis in the kubekins e2e image #33225

wants to merge 1 commit into from

Conversation

upodroid
Copy link
Member

@upodroid upodroid commented Aug 5, 2024

/cc @dims

@k8s-ci-robot k8s-ci-robot requested a review from dims August 5, 2024 18:40
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/images area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 5, 2024
BenTheElder
BenTheElder reviewed Aug 5, 2024
View reviewed changes
images/kubekins-e2e-v2/Dockerfile
@@ -74,6 +74,13 @@ RUN wget -O google-cloud-sdk.tar.gz -q $GCLOUD_SDK_URL && \
gcloud components install alpha beta && \
gcloud info | tee /workspace/gcloud-info.txt

# Install aws cli
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned about making this image even more risky to update.

Where are we using the CLI instead of some tool that links the SDK?

Copy link
Member

@BenTheElder BenTheElder Aug 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(if we could remove gcloud we should, but that requires eliminating kube-up realistically, which is not happening anytime soon)

Copy link
Member Author

@upodroid upodroid Aug 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

az cli is installed via apt and isn't an issue. You should be able to tweak it further on job execution if necessary. So many capz/sig-windows jobs install the cli on every run :( hundreds of times a day

The aws cli is also like that as well, the zip gets dropped in /usr/local/bin along with the self contained python libraries.

They can be updated without affecting the rest of the image tooling.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So many capz/sig-windows jobs install the cli on every run :( hundreds of times a day

The aws cli is also like that as well, the zip gets dropped in /usr/local/bin along with the self contained python libraries.

Yes, but on the other hand this means the version installed is controlled by the test code.
We have lots of things we live-install and increasingly only depend on the image for bootstrapping (e.g. go 1.21+ toolchain)

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@dims dims Awaiting requested review from dims

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/images area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@upodroid @k8s-ci-robot @k8s-triage-robot @BenTheElder