Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes-admins group to help fight spam #4994

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

kubernetes-admins group to help fight spam #4994

wants to merge 1 commit into from
+7 −0

Conversation

dims
Copy link
Member

@dims dims commented May 31, 2024

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 31, 2024
@k8s-ci-robot k8s-ci-robot added the area/github-management Issues or PRs related to GitHub Management subproject label May 31, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 31, 2024
jasonbraganza
jasonbraganza approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@jasonbraganza jasonbraganza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering @dims proactive yeoman work, this is a blindfolded yes

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, jasonbraganza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2024
@jasonbraganza
Copy link
Member

/hold

will also wait for the other, more experienced folk, to weigh in

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2024
@MadhavJivrajani
Copy link
Contributor

MadhavJivrajani commented Jun 8, 2024 •
edited
Loading

I am okay with this only if we can absolutely not come up with an alternative. I would prefer not adding admin privileges beyond the set of GH admins and required bots.

One solution that I am currently tinkering with is since the k8s-ci-robot has admin access already, a prow plugin that can recognise comments like /delete-issue and we can add in @dims as someone authorised to comment that and the k8s-ci-robot can handle the deletion for us.

@dims
Copy link
Member Author

dims commented Jun 8, 2024

One solution that I am currently tinkering with is since the k8s-ci-robot has admin access already, a prow plugin that can recognise comments like /delete-issue and we can add in @dims as someone authorised to comment that and the k8s-ci-robot can handle the deletion for us.

works for me!

@dims dims closed this Jun 14, 2024
@dims dims reopened this Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonbraganza jasonbraganza jasonbraganza approved these changes

@Priyankasaggu11929 Priyankasaggu11929 Awaiting requested review from Priyankasaggu11929

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dims @k8s-ci-robot @jasonbraganza @MadhavJivrajani