-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add kube_node_status_images metric #2555
base: main
Are you sure you want to change the base?
feat: Add kube_node_status_images metric #2555
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hausertt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This issue is currently awaiting triage. If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an interesting idea, though I have concerns about the number of metrics exposed. I'm interested in thoughts from others but would at least say this should be an opt-in metric. |
What this PR does / why we need it:
Collects metrics of container images present on the node. With the recent growth in image sizes, especially for self-hosted AI solutions, monitoring these metrics can help fix node-pressure.
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Increases one metric: kube_node_status_images
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #