-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: #2501 Count volumes attached to a node #2507
base: main
Are you sure you want to change the base?
feat: #2501 Count volumes attached to a node #2507
Conversation
I understand what you're trying to achieve here, I wonder though if it would be easier to attach a node label to the |
Thanks for the suggestion, from my understanding @thommeo wants to get the number of volumns currently attached from the perspective of node, and kube_volumeattachment_status_attached is from volumnattachment from volumeattachments to count the number of volumns he is attached to by that node attchment. From my personal understanding and implementation point of view, I think creating a metric will be better understood, the current implementation is not so complex, so that the use of the customer will be more convenient! |
/triage accepted |
…node # Conflicts: # internal/store/node_test.go
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: LiuQhahah The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Count volumes attached to a node
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
increaser two metrics: kube_node_volumes_attached_count and kube_node_volumes_in_use_count
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2501