Propagate IG NodeLabels to k8s nodes in Hetzner #16739
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
/cc @hakman |
hakman
requested changes
Aug 7, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rifelpet
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/test all |
1 similar comment
|
/test all |
rifelpet
force-pushed
the
hetzner-labels
branch
from
1414f91
to
3938ba9
Compare
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16159
This adds Hetzner server labels for the instance group nodeLabels. kops-controller then recognizes these server labels and sets them on the associated k8s node.
I'm marking this WIP as we may need to change this approach due to label length limits in the Hetzner API:
https://docs.hetzner.com/cloud/servers/getting-started/creating-a-server/
The Hetzner CCM mentions support for the
node.kubernetes.io/exclude-from-external-load-balancerslabel included in the integration test output changes: hetznercloud/hcloud-cloud-controller-manager#182 (comment) which is 55 characters on its own, so with the prefix I've added it exceeds the length limit. I considered storing these elsewhere like in userdata and having kops-controller parse them out of thehcloud.Server's userdata, except hcloud doesn't expose userdata in read operations, it is a write-only field.Therefore I think our only option is to use a shorter prefix
/wip