Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastly: Authenticate to a private bucket as origin #6509

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Mar 1, 2024

Define the VCL configuration needed to authenticate to GCS private bucket and use it as origin. This configuration leverage S3 authentification mechanism.
The endpoint is currently not publicly exposed.

Define the VCL configuration needed to authenticate to GCS private
bucket and use it as origin. This configuration leverage S3
authentification mechanism.
The endpoint is currently not publicly exposed.

Signed-off-by: Arnaud Meukam <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Mar 1, 2024
@ameukam
Copy link
Member Author

ameukam commented Mar 1, 2024

I had to pass the variables manually while running terraform apply for this config.

@ameukam
Copy link
Member Author

ameukam commented Mar 1, 2024

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2024
@ameukam
Copy link
Member Author

ameukam commented Mar 1, 2024

To test. add to the /etc/hosts:

151.101.0.204   cdn.dl-sandbox.k8s.dev
2a04:4e42::204 cdn.dl-sandbox.k8s.dev

and run cd $(mktemp -d) && curl -fSsLv -O http://cdn.dl-sandbox.k8s.dev/release/v1.29.1/kubernetes-node-linux-amd64.tar.gz && tar -xvzf kubernetes-node-linux-amd64.tar.gz

@BenTheElder
Copy link
Member

I had to pass the variables manually while running terraform apply for this config.

Can we at least add a comment outlining how to obtain the values?

@ameukam
Copy link
Member Author

ameukam commented Mar 5, 2024

I had to pass the variables manually while running terraform apply for this config.

Can we at least add a comment outlining how to obtain the values?

@BenTheElder We could use terraform to passe the values. Put the creds required in a GCP Secret and get them using https://registry.terraform.io/providers/hashicorp/google/latest/docs/data-sources/secret_manager_secret_version. This implies the operator to have some GCP permissions binded to the GCP secret.

@BenTheElder
Copy link
Member

@BenTheElder We could use terraform to passe the values. Put the creds required in a GCP Secret and get them using https://registry.terraform.io/providers/hashicorp/google/latest/docs/data-sources/secret_manager_secret_version. This implies the operator to have some GCP permissions binded to the GCP secret.

SGTM, I'm also fine with manual (like deploying boskos resources...) as long as we leave some markdown covering how this works for the next people doing this :-)

@ameukam
Copy link
Member Author

ameukam commented Mar 20, 2024

cc @dims @upodroid

Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ameukam
Copy link
Member Author

ameukam commented Mar 20, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit bd4b2d2 into kubernetes:main Mar 20, 2024
3 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants