Add protocol aware GetPorts function #2738
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @TortillaZHawaii. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
needs-ok-to-test
k8s-ci-robot
added
the
size/L
|
/assign @mmamczur |
|
/lint |
There was a problem hiding this comment.
@TortillaZHawaii: 1 warning.
In response to this:
/lint
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
TortillaZHawaii
force-pushed
the
dwysocki-protocol-specific-get-ports
branch
from
e4448a5
to
1d73a25
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: TortillaZHawaii The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Mixed protocol feature cannot rely on existing utils.GetPorts as it returns all ports in the spec, ignoring protocol.
TortillaZHawaii
force-pushed
the
dwysocki-protocol-specific-get-ports
branch
from
1d73a25
to
5bea588
Compare
|
/lint |
There was a problem hiding this comment.
@TortillaZHawaii: 0 warnings.
In response to this:
/lint
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Mixed protocol feature cannot rely on existing utils.GetPorts as it returns all ports in the spec, ignoring protocol.
Part of the #2734