Change default lease name for vpa-recommender to "vpa-recommender-lease"

[raywainman]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Changes the default lease name for the vpa-recommender to vpa-recommender-lease as this can sometimes conflict with managed deployments of HPA and VPA. See #7461.

Though changing the default here is possibly disruptive during upgrade, we believe it is the right path forward to avoid future outages. See the discussion in #7461 where we also discuss the possible scenarios during upgrade where there could temporarily be two leaders.

Which issue(s) this PR fixes:

#7461

Does this PR introduce a user-facing change?

- Changes the default vpa-recommender leader election lease name to `vpa-recommender-lease`. This CAN result in a situation where VPA would temporarily have two leaders during an upgrade operation. This should be harmless as the two VPA leaders would theoretically be writing the same recommendations. See #7461.

[raywainman]

/assign @adrianmoisey
/assign @voelzmo
/assign @kwiesmueller

[adrianmoisey]

/lgtm

[adrianmoisey]

Oh,

autoscaler/vertical-pod-autoscaler/deploy/vpa-rbac.yaml

Lines 412 to 413 in 59aefbc

	resourceNames:
	- vpa-recommender

also needs updating

[omerap12]

#7498 (comment)

To remove the lgtm label

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: raywainman
Once this PR has been reviewed and has the lgtm label, please ask for approval from kwiesmueller. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• vertical-pod-autoscaler/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[omerap12]

/lgtm cancel

[omerap12]

/assign @raywainman