-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag to force remove long unregistered nodes #7493
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BigDarkClown The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @BigDarkClown, the mandatory test case Thanks! |
There are the gofmt and spelling errors, due to which this test case failed. Run |
6bdc548
to
0e6f76c
Compare
Thanks @Shubham82, I've updated now. Turns out that gofmt picked up a lot of problems in cloudproviders I've modified. |
0e6f76c
to
f293f76
Compare
f293f76
to
d1969d4
Compare
What type of PR is this?
/kind feature
What this PR does / why we need it:
Problem:
The Cluster Autoscaler sometimes cannot remove long unregistered nodes. This happens when removing them would leave their node group with fewer than the minimum size required. This wastes resources, as the nodes cannot be used and might be as well deleted.
Solution:
Background:
Does this PR introduce a user-facing change?