Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release chart v3.12.2 #1578

Merged
merged 10 commits into from
Oct 7, 2024
Merged

Release chart v3.12.2 #1578

merged 10 commits into from
Oct 7, 2024

Conversation

stevehipwell
Copy link
Contributor

What this PR does / why we need it:
This PR released the v3.12.2 that's on the master branch.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1552

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 7, 2024
@stevehipwell stevehipwell mentioned this pull request Oct 7, 2024
Open
@stevehipwell
Copy link
Contributor Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 7, 2024
@stevehipwell
Copy link
Contributor Author

/retest

@stevehipwell
Copy link
Contributor Author

@dgrisonnet this PR finishes off the work from #1568. The failing job is unrelated to any changes in this PR, can it be skipped?

@dgrisonnet
Copy link
Member

I'll double check, it seems very odd

@dgrisonnet dgrisonnet mentioned this pull request Oct 7, 2024
Merged
@dgrisonnet
Copy link
Member

The image we use in CI was recently updated. I assume it uses a new go version that might not be supported by this golangci-lint version. I've tried updating it.

treksler and others added 10 commits October 7, 2024 21:59
@stevehipwell
Copy link
Contributor Author

Thanks @dgrisonnet. I've rebased on your chnages.

@dgrisonnet
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, stevehipwell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2024
@k8s-ci-robot k8s-ci-robot merged commit 65945d2 into kubernetes-sigs:release-0.7 Oct 7, 2024
9 checks passed
@stevehipwell stevehipwell deleted the release-chart-v3.12.2 branch October 8, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

Assignees

@dgrisonnet dgrisonnet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@stevehipwell @dgrisonnet @k8s-ci-robot @treksler @senges @the-technat @jimmy-ungerman @seankhliao