Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chart): Added changes for v3.11.0 #1302

Merged
merged 1 commit into from
Jul 28, 2023
Merged

feat(chart): Added changes for v3.11.0 #1302

merged 1 commit into from
Jul 28, 2023

Conversation

stevehipwell
Copy link
Contributor

@stevehipwell stevehipwell commented Jul 26, 2023 •
edited
Loading

What this PR does / why we need it:
This PR makes the code changes for the v3.11.0 chart release which includes the following changes.

  • Updated Metrics Server to v0.6.4
  • Updated addon resizer to v1.8.19
  • Fixed inconsistent addon resizer defaults

After this has been merged to master I'll open a PR to the release branch to actually release the chart.

Which issue(s) this PR fixes:
Fixes #1299

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 26, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 26, 2023
@stevehipwell
Copy link
Contributor Author

/retest

@dashpole
Copy link

/assign @serathius
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 27, 2023
@serathius serathius mentioned this pull request Jul 28, 2023
Merged
@stevehipwell stevehipwell force-pushed the chart-v3-11-0 branch 2 times, most recently from 34ade83 to f8ab32c Compare July 28, 2023 09:35
@serathius
Copy link
Contributor

/lgtm
/approve

@serathius serathius closed this Jul 28, 2023
@serathius serathius reopened this Jul 28, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius, stevehipwell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius
Copy link
Contributor

(missclick)

@serathius
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2023
@stevehipwell
Copy link
Contributor Author

@serathius I'm going to push up a change to this PR to provide the same default resource requests as would be in the manifests. I think this will be better for consistency.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 28, 2023
@serathius
Copy link
Contributor

Agree

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2023
@stevehipwell
Copy link
Contributor Author

/retest

3 similar comments
@stevehipwell
Copy link
Contributor Author

/retest

@stevehipwell
Copy link
Contributor Author

/retest

@stevehipwell
Copy link
Contributor Author

/retest

@stevehipwell
Copy link
Contributor Author

@serathius it looks like Prow has got stuck somehow here as I can't see any pending jobs for this PR?

@serathius
Copy link
Contributor

I think it should be merged soonish?
image

@stevehipwell stevehipwell mentioned this pull request Jul 28, 2023
Merged
@stevehipwell
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit aea89d8 into kubernetes-sigs:master Jul 28, 2023
3 checks passed
@stevehipwell stevehipwell deleted the chart-v3-11-0 branch July 28, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serathius serathius serathius left review comments

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

Assignees

@serathius serathius

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release Helm chart for v0.6.4
4 participants
@stevehipwell @dashpole @serathius @k8s-ci-robot