Add release binaries #1298
Merged
Add release binaries #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/S
wzshiming
commented
Jul 25, 2023
|
/assign @dgrisonnet |
k8s-ci-robot
added
triage/accepted
dgrisonnet
reviewed
Jul 28, 2023
wzshiming
force-pushed
the
feat/release-binaries
branch
from
351ba9b
to
9ede487
Compare
k8s-ci-robot
added
size/M
wzshiming
force-pushed
the
feat/release-binaries
branch
4 times, most recently
from
8cca191
to
7911f54
Compare
|
Done |
dgrisonnet
reviewed
Aug 16, 2023
wzshiming
force-pushed
the
feat/release-binaries
branch
from
7911f54
to
e43f3e0
Compare
|
Done |
|
/test pull-metrics-server-test-version |
k8s-ci-robot
added
the
lgtm
serathius
reviewed
Aug 17, 2023
serathius
reviewed
Aug 17, 2023
k8s-ci-robot
removed
the
lgtm
wzshiming
commented
Aug 17, 2023
wzshiming
force-pushed
the
feat/release-binaries
branch
3 times, most recently
from
9075f91
to
0feb714
Compare
|
Done |
|
/test pull-metrics-server-test-version |
1 similar comment
|
/test pull-metrics-server-test-version |
serathius
reviewed
Aug 18, 2023
serathius
reviewed
Aug 18, 2023
wzshiming
force-pushed
the
feat/release-binaries
branch
from
daaaa04
to
035dade
Compare
|
/lgtm Possible followup for making the |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, serathius, wzshiming The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I had tested
https://github.com/wzshiming/metrics-server/actions/runs/5724499140/job/15511107037
https://github.com/wzshiming/metrics-server/releases/tag/v0.7.0-alpha.2
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1285