Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Self nominate Kevin Hannon for approval rights #758

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Self nominate Kevin Hannon for approval rights #758

wants to merge 1 commit into from

Conversation

kannon92
Copy link
Contributor

@kannon92 kannon92 commented Jan 17, 2025 •
edited
Loading

What type of PR is this?

/kind documentation

What this PR does / why we need it:

I have been active in JobSet since the beginning of the project.

I led a KEP for startup policy and I have closely worked with @andreyvelich on kubeflow training v2.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

I'll use this as tracking list for PRs related to becoming a maintainer of jobset.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 17, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kannon92
Once this PR has been reviewed and has the lgtm label, please assign ahg-g for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 17, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 17, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-jobset ready!

Name Link
🔨 Latest commit 42f2b2c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-jobset/deploys/678ac2cb97e1ab000881dab6
😎 Deploy Preview https://deploy-preview-758--kubernetes-sigs-jobset.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kannon92 kannon92 mentioned this pull request Jan 17, 2025
Open
@kannon92
Copy link
Contributor Author

/hold

/assign @ahg-g @danielvegamyhre

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2025
@kannon92 kannon92 mentioned this pull request Jan 17, 2025
Open
andreyvelich
andreyvelich reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@andreyvelich andreyvelich left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I strongly support Kevin's nomination, given number of contributions he has made to JobSet and Kubeflow Trainer.
Thank you for your hard work 🎉
/lgtm

site/OWNERS
@@ -2,3 +2,4 @@

approvers:
- moficodes
- kannon92
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update the site OWNERs since you are the root owner ?

OWNERS
@@ -3,5 +3,6 @@
approvers:
- ahg-g
- danielvegamyhre
- kannon92
reviewers:
- kannon92
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, you can remove yourself from the reviewers.

@k8s-ci-robot
Copy link
Contributor

@andreyvelich: changing LGTM is restricted to collaborators

In response to this:

I strongly support Kevin's nomination, given number of contributions he has made to JobSet.
Thank you for your hard work 🎉
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@danielvegamyhre
Copy link
Contributor

/lgtm

Thanks for your contributions Kevin!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreyvelich andreyvelich andreyvelich left review comments

@ahg-g ahg-g Awaiting requested review from ahg-g

@moficodes moficodes Awaiting requested review from moficodes

Assignees

@ahg-g ahg-g

@danielvegamyhre danielvegamyhre

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kannon92 @k8s-ci-robot @danielvegamyhre @andreyvelich @ahg-g