-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WithWaitDuration
ClusterOpts function
#479
base: main
Are you sure you want to change the base?
Add WithWaitDuration
ClusterOpts function
#479
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: liam-mackie The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @liam-mackie! |
Hi @liam-mackie. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This needs to be rebased. @liam-mackie Can you please take care of this ? |
b860d28
to
899b754
Compare
Done, sorry for the delay! Happened to make this change just before the structure of the third-party providers changed! |
/ok-to-test |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This allows
kwok
clusters to be created with a custom wait time option.Which issue(s) this PR fixes:
Fixes #478
Special notes for your reviewer:
I wasn't sure if it was better to have a receiver method on
*Cluster
or use theClusterOptions
. I couldn't find a concrete usage example of the Cluster Options forkwok
anywhere, but thought it to be the least impactful change to allow this feature to be set. This is my first PR to the e2e-framework, so any feedback is appreciated!Does this PR introduce a user-facing change?