Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add tilt provider file #297

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

richardcase
Copy link
Member

What this PR does / why we need it:

This adds a tilt-provider.json file to make it easier to use Tilt with the provider using the instructions from the upstream CAPI docs.

To test, I used a tilt-settings.json file like this:

{
  "enable_providers": [
    "kubeadm-bootstrap",
    "kubeadm-control-plane",
    "kubevirt"
  ],
  "default_registry": "gcr.io/richardcase",
  "provider_repos": [
    "/home/richard/code/oss/cluster-api-provider-kubevirt"
  ],
  "kustomize_substitutions": {
    "CLUSTER_TOPOLOGY": "true",
    "EXP_CLUSTER_RESOURCE_SET": "true",
    "EXP_MACHINE_POOL": "true"
  },
  "debug": {
    "kubevirt": {
      "continue": true,
      "port": 30000
    }
  }
}

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release notes:

Add tilt-provider file to enable Tilt development workflow.

This adds a `tilt-provider.json` file to make it easier to use Tilt
with the provider using the instructions from the upstream CAPI docs.

Signed-off-by: Richard Case <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 4, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 4, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11665446038

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 59.245%

Totals Coverage Status
Change from base Build 11236691655: 0.0%
Covered Lines: 1570
Relevant Lines: 2650

💛 - Coveralls

Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold

please drop the hold unless you are waiting for another review

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2024
@richardcase
Copy link
Member Author

Thanks @neolit123.

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0b6306e into kubernetes-sigs:main Nov 4, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants