Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix for enableLinux node parameter #2078

Merged

Conversation

ElijahQuinones
Copy link
Member

Is this a bug fix or adding new feature?
This is a bug fix
What is this PR about? / Why do we need it?
Previously the parameter enableLinux did not work because it was set to true regardless of what you pass in as a parameter
What testing is done?
I deployed my dev cluster with the change and ran the following command to install the driver with enableLinux set to false

helm upgrade \
  --install aws-ebs-csi-driver \
  --namespace kube-system \
  ./charts/aws-ebs-csi-driver \
  --set controller.replicaCount=1 \
  --set image.pullPolicy=Always \
  --set controller.logLevel=7 \
  --set image.repository="533267024531.dkr.ecr.us-west-2.amazonaws.com/aws-ebs-csi-driver"\
  --set image.tag="TEST-ELIJAH-linux-amd64-al2023" \
--set node.enableLinux="false"

I then ran kubectl -n kube-system get daemonset.apps with the following output

NAME                           DESIRED   CURRENT   READY   UP-TO-DATE   AVAILABLE   NODE SELECTOR   AGE
aws-cloud-controller-manager   1         1         1       1            1           <none>          48m
cilium                         4         4         4       4            4           <none>          48m
kops-controller                1         1         1       1            1           <none>          48m

Finally i ran the same helm command but with enableLinux set to true and got the following output.

helm upgrade \
  --install aws-ebs-csi-driver \
  --namespace kube-system \
  ./charts/aws-ebs-csi-driver \
  --set controller.replicaCount=1 \
  --set image.pullPolicy=Always \
  --set controller.logLevel=7 \
  --set image.repository="533267024531.dkr.ecr.us-west-2.amazonaws.com/aws-ebs-csi-driver"\
  --set image.tag="TEST-ELIJAH-linux-amd64-al2023" \
--set node.enableLinux="true"

 kubectl -n kube-system get daemonset.apps
NAME                           DESIRED   CURRENT   READY   UP-TO-DATE   AVAILABLE   NODE SELECTOR            AGE
aws-cloud-controller-manager   1         1         1       1            1           <none>                   49m
cilium                         4         4         4       4            4           <none>                   49m
ebs-csi-node                   4         4         4       4            4           kubernetes.io/os=linux   5s
kops-controller                1         1         1       1            1           <none>                   49m



Additionally I ran make update && make verify && make test

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 1, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @ElijahQuinones. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 1, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 1, 2024
Copy link
Contributor

@ConnorJC3 ConnorJC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2024
@ConnorJC3
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 1, 2024
Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

github-actions bot commented Jul 1, 2024

Code Coverage Diff

This PR does not change the code coverage

@torredil
Copy link
Member

torredil commented Jul 1, 2024

/retest

Copy link
Contributor

@AndrewSirenko AndrewSirenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the fix.

@torredil
Copy link
Member

torredil commented Jul 2, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit 83fed8c into kubernetes-sigs:master Jul 2, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants