Add compatibility workaround for A1 instance family

[ConnorJC3]

Is this a bug fix or adding new feature?

Bug fix

What is this PR about? / Why do we need it?

Adds compatibility for running on instances with the a1 instance family

What testing is done?

$ helm install aws-ebs-csi-driver . --set a1CompatibilityDaemonSet=true --set image.repository=368597081700.dkr.ecr.us-west-2.amazonaws.com/aws-ebs-csi-driver --set image.tag=fdb98666fa056862748ca337049f907d7b080e25
NAME: aws-ebs-csi-driver
LAST DEPLOYED: Wed Oct 25 15:15:29 2023
NAMESPACE: default
STATUS: deployed
REVISION: 1
NOTES:
To verify that aws-ebs-csi-driver has started, run:

    kubectl get pod -n default -l "app.kubernetes.io/name=aws-ebs-csi-driver,app.kubernetes.io/instance=aws-ebs-csi-driver"

NOTE: The [CSI Snapshotter](https://github.com/kubernetes-csi/external-snapshotter) controller and CRDs will no longer be installed as part of this chart and moving forward will be a prerequisite of using the snap shotting functionality.

$ kubectl get daemonsets.apps                   
NAME                    DESIRED   CURRENT   READY   UP-TO-DATE   AVAILABLE   NODE SELECTOR            AGE
ebs-csi-node            0         0         0       0            0           kubernetes.io/os=linux   3m30s
ebs-csi-node-a1compat   1         1         1       1            1           kubernetes.io/os=linux   3m30s

[ConnorJC3]

/retest

[ConnorJC3]

/retest

[AndrewSirenko]

/lgtm

Excited for optimize makefile & run.sh task to clean up 🍝 though...

[wmesard]

One question

[wmesard]

Why is this Fargate-specific check necessary?

[ConnorJC3]

I'm not sure if it's absolutely necessary here, in order to make the minimal change necessary I pulled it from our defaults: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/charts/aws-ebs-csi-driver/values.yaml#L319-L327
(so the resulting change is the default + the a1 restriction, rather than the default replaced by the a1 restriction)

Even if it's not actually necessary, it definitely won't hurt, and considering we don't control what EKS fargate does it would be bad if in some future they started vending nodes with an a1 "instance type" and we tried to run on them.

[wmesard]

(Out of scope for this PR, but it would be better if this extracted the information from the resulting image, instead of passing it in. Having it hardcoded here and in the Makefile is tech debt that will bite us eventually.)

[AndrewSirenko]

Adding to our 'optimize makefile & run.sh task' backlog task.

[k8s-ci-robot]

@wmesard: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[AndrewSirenko]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndrewSirenko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [AndrewSirenko]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[AndrewSirenko]

/retest

[ConnorJC3]

/retest