KTOR-7777 Release proper InetSocketAddress #4482
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osipxd
reviewed
Nov 15, 2024
There was a problem hiding this comment.
Thank you for the fix! I've created an issue not to miss this change from release notes:
- KTOR-7777 Connections aren't released properly if there are multiple parallel connections to the same address
Do you think you can write tests covering this issue?
osipxd
changed the title
I could try on Monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Client
Motivation
We encountered a lot of crashes after updating to the Ktor v3 with the root causes:
Caused by: java.lang.IllegalStateException: The number of released permits cannot be greater than 100The problem is that we request 4 calls to the same endpoint asynchronously. However, InetSocketAddress(host, port) could have different results (IP address could change) - the current solution stores only the last address.
Solution
Store InetSocketAddress separately per connect request.