Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KTOR-7679 Allow disabling body decoding on server #4444

Open
wants to merge 16 commits into
base: 3.1.0-eap
Choose a base branch
from

Conversation

e5l
Copy link
Member

@e5l e5l commented Nov 2, 2024

Fix KTOR-7679 Allow to Disable Body Decompression on the Server for a specific call

@e5l e5l requested a review from marychatte November 2, 2024 07:52
@e5l e5l self-assigned this Nov 2, 2024
@e5l e5l force-pushed the e5l/call-compression-switch branch from 5aac0ae to 5fe5955 Compare November 2, 2024 08:11
}

@Test
fun testDisableCallDecoding() = testApplication {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why function suppressDecompression() is not used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@e5l
Copy link
Member Author

e5l commented Nov 4, 2024

Hey, @marychatte! Thank you for the review. I've spotted other issue, let me check

osipxd and others added 11 commits November 14, 2024 11:25
* Use stdlib `use` extension-function
* Update type checks
…4411)

* Drop `jvmAndNix` shared source set
* Commonize `ktor-network` and `ktor-network-tls`
* Support TCP and Unix sockets for wasm-js and js on Node
* Move `supportsUnixDomainSockets` to posix and use Platform instead of expect/actual
* Support multiple client engines for JS/WasmJs
* CIO client Js/WasmJs support
* Enable CIO tests in client tests
* Make client engines `data object` to have `toString`
* Make ClientLoader work with multiple engines on js/wasmJs and so test CIO engine on nodejs(js+wasmJs)
* KTOR-6632 Support receiving multipart data with Ktor client
@e5l e5l force-pushed the e5l/call-compression-switch branch from dda2176 to bcdb40c Compare November 15, 2024 12:04
@e5l e5l requested a review from marychatte November 15, 2024 12:05
@e5l
Copy link
Member Author

e5l commented Nov 15, 2024

Hey, @marychatte! Sorry for the delay, there was an issue with body decompression.
Ready to check!

Copy link
Member

@marychatte marychatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants