Skip to content
This repository has been archived by the owner on Nov 1, 2018. It is now read-only.

API 10 support (using NineOldAndroids) #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

perpetuatingcuriosity
Copy link

Hey krossovochkin, thanks so much making the original library compatible with RecyclerView! I needed compatibility back to API level 10, so this commit includes a combination of your modifications on the original lib with the NineOldAndroids code from your link.

I’m relatively new to android, so I wanted to note:

  • I was unable to test with your sample code, but I’ve tested with my app on 2.3.
  • I also added the most recent version of NineOldAndroids, but because I had trouble opening your files it will probably still need to be added as a library from Android Studio.

Great work on the lib! Hope this is helpful!

@krossovochkin
Copy link
Owner

Thanks
Merging your pull request is not a very good idea, because sample application even will not be able to be compiled.
Also, I don't think that creating separate NoaActivity and NoaTouchListener is a good idea too.
I think it should be better if all this logic will be implemented inside, something like:

if (old version) {
    // use nine old androids
} else {
    // use normal animations code
}

I will think about how to do it better.

But supporting API < 15 is not the main goal. This implementation has some problems on new versions, so I'd better concentrate on them.
I will not close your pull request to not to forget.

@krossovochkin krossovochkin changed the title added sample code compatible with all API levels using NineOldAndroids l... API 10 support (using NineOldAndroids) May 23, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants