Merge pull request #53 from neuroid/errors

Do not modify files if parsing fails

envplate.go

@@ -116,6 +116,10 @@ func (h *Handler) parse(file string) error {
 
 	})
 
+	if len(errors) > 0 {
+		return errors[0]
+	}
+
 	if h.DryRun {
 		Log(DEBUG, "Expanding all references in '%s' without doing anything (dry-run)", file)
 		Log(RAW, parsed)
@@ -143,10 +147,6 @@ func (h *Handler) parse(file string) error {
 
 	}
 
-	if len(errors) > 0 {
-		return errors[0]
-	}
-
 	return nil
 
 }

envplate_test.go

@@ -229,11 +229,30 @@ func TestStrictParse(t *testing.T) {
 		file = "test/template4.txt"
 	)
 
-	defer _restore(file)
-
 	err := handler.parse(file)
 	assert.Error(err)
 
 	assert.Equal("'test/template4.txt' requires undeclared environment variable 'ANOTHER_DATABASE', but cannot use default 'db2.example.com' (strict-mode)", err.Error())
 
 }
+
+func TestAbortOnParseErrors(t *testing.T) {
+
+	assert := assert.New(t)
+	handler := &Handler{
+		Backup: true,
+		Strict: true,
+	}
+
+	var (
+		file     = "test/template4.txt"
+		template = _read(t, file)
+	)
+
+	err := handler.parse(file)
+	assert.Error(err)
+
+	assert.Equal(template, _read(t, file))
+	assert.NoFileExists(fmt.Sprintf("%s.bak", file))
+
+}