Add test-case for curl ipfs:// integrity controls #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests integrity controls in the ipfs integration of curl. At the time of writing it seems there's full trust in the ipfs gateway, as demonstrated by this example plot:
sh4d0wup acts as a malicious ipfs gateway, resulting in this:
In ipfs there's a concept of trustless gateways, but I'm not sure CAR and
ipfs-carsupport responses that are both authenticated and still streamed.This may or may not be a problem for you, curl is assuming the gateway runs on the local computer and is therefore as trustworthy as the curl process itself.