-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#14] Add type family to display list of types separated by commas #22
Open
dalpd
wants to merge
1
commit into
kowainik:main
Choose a base branch
from
winkduo:14-comma-separated
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
{-# LANGUAGE TypeFamilies #-} | ||
{-# LANGUAGE TypeInType #-} | ||
{-# LANGUAGE TypeOperators #-} | ||
{-# LANGUAGE UnicodeSyntax #-} | ||
{-# LANGUAGE UndecidableInstances #-} | ||
{- | | ||
Copyright: (c) 2019-2020 Dmitrii Kovanikov | ||
(c) 2020-2021 Kowainik | ||
SPDX-License-Identifier: MPL-2.0 | ||
Maintainer: Dmitrii Kovanikov <[email protected]> | ||
Kowainik <[email protected]> | ||
|
||
This module provides type-level helpers for operations on type-level lists. | ||
-} | ||
module Type.Errors.Helpers | ||
( -- * Helper type families | ||
Intercalate, | ||
) where | ||
|
||
import GHC.TypeLits | ||
|
||
-- | Internal type family to prepend all the elements of a list, used to | ||
-- construct `Intersperse`. | ||
type family PrependToAll (sep :: a) (xs :: [a]) :: [a] where | ||
PrependToAll _ '[] = '[] | ||
PrependToAll sep (x ': xs) = sep ': x ': PrependToAll sep xs | ||
|
||
-- | Internal type family to intersperse a list with a given seperator, | ||
-- type-level version of `Data.List.intersperse`. | ||
type family Intersperse (sep :: a) (xs :: [a]) :: [a] where | ||
Intersperse _ '[] = '[] | ||
Intersperse sep (x ': xs) = x ': PrependToAll sep xs | ||
|
||
-- | Internal type family to concatenate all the type-level symbols in a list. | ||
type family Concat (xs :: [Symbol]) :: Symbol where | ||
Concat '[] = "" | ||
Concat (x:xs) = AppendSymbol x (Concat xs) | ||
|
||
{- | Type family to insert a symbol in between a given list of symbols and concatenate. | ||
|
||
>>> :kind! Intercalate ", " '["Int", "String", "Bool"] | ||
Intercalate ", " '["Int", "String", "Bool"] :: Symbol | ||
= "Int, String, Bool" | ||
-} | ||
type family Intercalate (x :: Symbol) (xs :: [Symbol]) :: Symbol where | ||
Intercalate x xs = Concat (Intersperse x xs) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
{-# LANGUAGE TypeFamilies #-} | ||
{-# LANGUAGE TypeInType #-} | ||
{-# LANGUAGE TypeOperators #-} | ||
{-# LANGUAGE UnicodeSyntax #-} | ||
|
||
{-# LANGUAGE TypeFamilies #-} | ||
{-# LANGUAGE TypeInType #-} | ||
{-# LANGUAGE TypeOperators #-} | ||
{-# LANGUAGE UnicodeSyntax #-} | ||
{-# LANGUAGE UndecidableInstances #-} | ||
{- | | ||
Copyright: (c) 2019-2020 Dmitrii Kovanikov | ||
(c) 2020 Kowainik | ||
(c) 2020-2021 Kowainik | ||
SPDX-License-Identifier: MPL-2.0 | ||
Maintainer: Dmitrii Kovanikov <[email protected]> | ||
Kowainik <[email protected]> | ||
|
@@ -69,12 +69,15 @@ module Type.Errors.Pretty | |
-- * Reexports from "GHC.TypeLits" | ||
, TypeError | ||
|
||
-- * Helper internal type families | ||
-- * Helper type families | ||
, ToErrorMessage | ||
, CommaSeparated | ||
) where | ||
|
||
import GHC.TypeLits (ErrorMessage (..), Symbol, TypeError) | ||
|
||
import Data.Kind | ||
import GHC.TypeLits (AppendSymbol, ErrorMessage (..), Symbol, TypeError) | ||
import GHC.Generics | ||
import Type.Errors.Helpers (Intercalate) | ||
|
||
{- | Append two types automatically converting them to corresponding | ||
'ErrorMessage' constructors. | ||
|
@@ -114,3 +117,34 @@ type family ToErrorMessage (t :: k) :: ErrorMessage where | |
ToErrorMessage (t :: Symbol) = 'Text t | ||
ToErrorMessage (t :: ErrorMessage) = t | ||
ToErrorMessage t = 'ShowType t | ||
|
||
-- | Internal type family to go from a `Type` to a `Symbol` representation. | ||
-- The names for types without `Generic` instances have to be defined | ||
-- manually, and we do so for a handful of common types. | ||
type family TypeName (a :: Type) :: Symbol where | ||
TypeName Char = "Char" | ||
TypeName String = "String" | ||
TypeName Int = "Int" | ||
TypeName (Maybe a) = AppendSymbol "Maybe " (TypeName a) | ||
TypeName [a] = AppendSymbol "[" (AppendSymbol (TypeName a) "]") | ||
TypeName (D1 ('MetaData name _ _ _) _ _) = name | ||
TypeName a = TypeName (Rep a ()) | ||
|
||
-- | Internal type family to map over a list of `Type`s while applying | ||
-- `TypeName` to each, returning a list of `Symbol`s. | ||
type family CommaSeparated' (ts :: [Type]) :: [Symbol] where | ||
CommaSeparated' '[] = '[] | ||
CommaSeparated' (t ': ts) = TypeName t ': CommaSeparated' ts | ||
|
||
{- | Type family to display a list of types separated by commas. | ||
|
||
@ | ||
__data__ UserDefinedTypeDerivingGeneric = C1 | C2 __deriving__ Generic | ||
@ | ||
>>> :kind! CommaSeparated '[Int, String, Maybe Int, [[[Char]]], UserDefinedTypeDerivingGeneric] | ||
CommaSeparated '[Int, String, Maybe Int, [[[Char]]], UserDefinedTypeDerivingGeneric] :: Symbol | ||
= "Int, String, Maybe Int, [[String]], UserDefinedTypeDerivingGeneric" | ||
|
||
-} | ||
type family CommaSeparated (ts :: [Type]) :: Symbol where | ||
CommaSeparated ts = Intercalate ", " (CommaSeparated' ts) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this approach is not extensible. Users of
type-errors-pretty
cannot create new instances ofTypeName
. And the library cannot provide instances for all types 😞To solve this problem nicely, the
CommaSeparated
type family can return a type of kindErrorMessage
instead ofSymbol
. The type-level operator<>
already converts types and type-level symbols to a nice stringified representation that can be later reused in error messages.