Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#14] Add type family to display list of types separated by commas #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions src/Type/Errors/Helpers.hs
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
{-# LANGUAGE TypeFamilies #-}
{-# LANGUAGE TypeInType #-}
{-# LANGUAGE TypeOperators #-}
{-# LANGUAGE UnicodeSyntax #-}
{-# LANGUAGE UndecidableInstances #-}
{- |
Copyright: (c) 2019-2020 Dmitrii Kovanikov
(c) 2020-2021 Kowainik
SPDX-License-Identifier: MPL-2.0
Maintainer: Dmitrii Kovanikov <[email protected]>
Kowainik <[email protected]>

This module provides type-level helpers for operations on type-level lists.
-}
module Type.Errors.Helpers
( -- * Helper type families
Intercalate,
) where

import GHC.TypeLits

-- | Internal type family to prepend all the elements of a list, used to
-- construct `Intersperse`.
type family PrependToAll (sep :: a) (xs :: [a]) :: [a] where
PrependToAll _ '[] = '[]
PrependToAll sep (x ': xs) = sep ': x ': PrependToAll sep xs

-- | Internal type family to intersperse a list with a given seperator,
-- type-level version of `Data.List.intersperse`.
type family Intersperse (sep :: a) (xs :: [a]) :: [a] where
Intersperse _ '[] = '[]
Intersperse sep (x ': xs) = x ': PrependToAll sep xs

-- | Internal type family to concatenate all the type-level symbols in a list.
type family Concat (xs :: [Symbol]) :: Symbol where
Concat '[] = ""
Concat (x:xs) = AppendSymbol x (Concat xs)

{- | Type family to insert a symbol in between a given list of symbols and concatenate.

>>> :kind! Intercalate ", " '["Int", "String", "Bool"]
Intercalate ", " '["Int", "String", "Bool"] :: Symbol
= "Int, String, Bool"
-}
type family Intercalate (x :: Symbol) (xs :: [Symbol]) :: Symbol where
Intercalate x xs = Concat (Intersperse x xs)
52 changes: 43 additions & 9 deletions src/Type/Errors/Pretty.hs
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{-# LANGUAGE TypeFamilies #-}
{-# LANGUAGE TypeInType #-}
{-# LANGUAGE TypeOperators #-}
{-# LANGUAGE UnicodeSyntax #-}

{-# LANGUAGE TypeFamilies #-}
{-# LANGUAGE TypeInType #-}
{-# LANGUAGE TypeOperators #-}
{-# LANGUAGE UnicodeSyntax #-}
{-# LANGUAGE UndecidableInstances #-}
{- |
Copyright: (c) 2019-2020 Dmitrii Kovanikov
(c) 2020 Kowainik
(c) 2020-2021 Kowainik
SPDX-License-Identifier: MPL-2.0
Maintainer: Dmitrii Kovanikov <[email protected]>
Kowainik <[email protected]>
Expand Down Expand Up @@ -69,12 +69,15 @@ module Type.Errors.Pretty
-- * Reexports from "GHC.TypeLits"
, TypeError

-- * Helper internal type families
-- * Helper type families
, ToErrorMessage
, CommaSeparated
) where

import GHC.TypeLits (ErrorMessage (..), Symbol, TypeError)

import Data.Kind
import GHC.TypeLits (AppendSymbol, ErrorMessage (..), Symbol, TypeError)
import GHC.Generics
import Type.Errors.Helpers (Intercalate)

{- | Append two types automatically converting them to corresponding
'ErrorMessage' constructors.
Expand Down Expand Up @@ -114,3 +117,34 @@ type family ToErrorMessage (t :: k) :: ErrorMessage where
ToErrorMessage (t :: Symbol) = 'Text t
ToErrorMessage (t :: ErrorMessage) = t
ToErrorMessage t = 'ShowType t

-- | Internal type family to go from a `Type` to a `Symbol` representation.
-- The names for types without `Generic` instances have to be defined
-- manually, and we do so for a handful of common types.
type family TypeName (a :: Type) :: Symbol where
TypeName Char = "Char"
TypeName String = "String"
TypeName Int = "Int"
TypeName (Maybe a) = AppendSymbol "Maybe " (TypeName a)
TypeName [a] = AppendSymbol "[" (AppendSymbol (TypeName a) "]")
TypeName (D1 ('MetaData name _ _ _) _ _) = name
TypeName a = TypeName (Rep a ())
Comment on lines +121 to +131
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this approach is not extensible. Users of type-errors-pretty cannot create new instances of TypeName. And the library cannot provide instances for all types 😞

To solve this problem nicely, the CommaSeparated type family can return a type of kind ErrorMessage instead of Symbol. The type-level operator <> already converts types and type-level symbols to a nice stringified representation that can be later reused in error messages.


-- | Internal type family to map over a list of `Type`s while applying
-- `TypeName` to each, returning a list of `Symbol`s.
type family CommaSeparated' (ts :: [Type]) :: [Symbol] where
CommaSeparated' '[] = '[]
CommaSeparated' (t ': ts) = TypeName t ': CommaSeparated' ts

{- | Type family to display a list of types separated by commas.

@
__data__ UserDefinedTypeDerivingGeneric = C1 | C2 __deriving__ Generic
@
>>> :kind! CommaSeparated '[Int, String, Maybe Int, [[[Char]]], UserDefinedTypeDerivingGeneric]
CommaSeparated '[Int, String, Maybe Int, [[[Char]]], UserDefinedTypeDerivingGeneric] :: Symbol
= "Int, String, Maybe Int, [[String]], UserDefinedTypeDerivingGeneric"

-}
type family CommaSeparated (ts :: [Type]) :: Symbol where
CommaSeparated ts = Intercalate ", " (CommaSeparated' ts)