Use query param for label deletion #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Smaug123 the change looks good to me. Have you tested it yourself? |
|
I only have easy access to a rather ancient Confluence. I'll try and remember to check on Monday what testing I did. |
|
Yep, just tested this locally against our on-prem Confluence. I used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I struggle greatly with Golang, so please assume that if it's possible to do anything wrong, I have done it wrong.)
The Confluence API is documented as preferring this endpoint when the label has slashes in.
I have not checked whether it's necessary to URL query-parameter escape this; maybe it is necessary?
(The whitespace change appears to satisfy
go fmt, but surprised me.)