blockquote: Fix invalid access

kovetskiy · Oct 5, 2024 · 33e5d1f · 33e5d1f
1 parent d5c41f6
commit 33e5d1f
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 3 deletions.
diff --git a/renderer/blockquote.go b/renderer/blockquote.go
@@ -118,13 +118,12 @@ func ParseBlockQuoteType(node ast.Node, source []byte) BlockQuoteType {
 				// Classifying the next text type node (midNode) will confirm that.
 				if t == None {
 					midNode := node.NextSibling()
-					rightNode := midNode.NextSibling()
 
-					if midNode.Kind() == ast.KindText {
+					if midNode != nil && midNode.Kind() == ast.KindText {
+						rightNode := midNode.NextSibling()
 						midTextNode := midNode.(*ast.Text)
 						if rightNode != nil && rightNode.Kind() == ast.KindText {
 							rightTextNode := rightNode.(*ast.Text)
-
 							if string(n.Text(source)) == "[" && string(rightTextNode.Text(source)) == "]" {
 								t = ghAlertsClassifier.ClassifyingBlockQuote(string(midTextNode.Text(source)))
 							}

diff --git a/testdata/quotes-droph1.html b/testdata/quotes-droph1.html
@@ -98,3 +98,7 @@ <h3 id="should-not-be-picked-up-and-converted-into-blockquote-macro">Should not
 <blockquote>
 <p>[NOTE]</p>
 </blockquote>
+<blockquote>
+<p><strong>TL;DR:</strong> Thingy!
+More stuff</p>
+</blockquote>
diff --git a/testdata/quotes-stripnewlines.html b/testdata/quotes-stripnewlines.html
@@ -96,3 +96,6 @@ <h3 id="should-not-be-picked-up-and-converted-into-blockquote-macro">Should not
 <blockquote>
 <p>[NOTE]</p>
 </blockquote>
+<blockquote>
+<p><strong>TL;DR:</strong> Thingy! More stuff</p>
+</blockquote>
diff --git a/testdata/quotes.html b/testdata/quotes.html
@@ -99,3 +99,7 @@ <h3 id="should-not-be-picked-up-and-converted-into-blockquote-macro">Should not
 <blockquote>
 <p>[NOTE]</p>
 </blockquote>
+<blockquote>
+<p><strong>TL;DR:</strong> Thingy!
+More stuff</p>
+</blockquote>
diff --git a/testdata/quotes.md b/testdata/quotes.md
@@ -88,3 +88,8 @@
 > [Hey !NOTE]
 
 > [NOTE]
+
+
+
+> **TL;DR:** Thingy!
+> More stuff