HT-6 Kostenevich #83
Open
HT-6 Kostenevich #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koretskiyav
reviewed
Nov 2, 2021
Comment on lines
+13
to
+17
| <Route | ||
| path="/" | ||
| exact | ||
| component={() => <Redirect to={`/restaurants`} />} | ||
| /> |
There was a problem hiding this comment.
вот так
Suggested change
| <Route | |
| path="/" | |
| exact | |
| component={() => <Redirect to={`/restaurants`} />} | |
| /> | |
| <Redirect exact from="/" to="/restaurants" /> |
koretskiyav
reviewed
Nov 2, 2021
| export const restaurantByProductIdSelector = createSelector( | ||
| [restaurantsSelector, (state, ownProps) => ownProps.product.id], | ||
| (restaurants, id) => { | ||
| const restaurant = Object.values(restaurants).find((restaurant) => |
There was a problem hiding this comment.
Вот это пересчитывается для каждого элемента корзины при каждом рендере. Можно сделать немного оптимальнее, разделив на 2 селектора. Покажу на своей домашке.
koretskiyav
reviewed
Nov 2, 2021
| {({ match }) => { | ||
| console.log(match.params); | ||
|
|
||
| switch (match.params.id) { |
There was a problem hiding this comment.
проще сделать несколько Route, покажу на своей домашке
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Сама домашка лёгкая, но есть один непонятный момент. Как лучше редиректить с '/'? в голове было куча вариантов, остановился на том что бы в Component передать '<Redirect to={
/restaurants} />', однако можно и просто передать компонент Restaurants, ну или в Component передать '<Route...>' и тд. Хотел бы вот об этом вот узнать, спасибо заранее.