HW6 Navruzov #77
Open
HW6 Navruzov #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koretskiyav
reviewed
Nov 2, 2021
| @@ -10,7 +10,7 @@ export default class App extends PureComponent { | |||
| <div> | |||
| <Header /> | |||
| <Switch> | |||
| <Route path="/" exact component={() => <h2>Home page</h2>} /> | |||
| <Route path="/" exact component={Restaurants} /> | |||
There was a problem hiding this comment.
тут должен быть Redirect, а не Route
koretskiyav
reviewed
Nov 2, 2021
| product, | ||
| amount, | ||
| subtotal, | ||
| increment, | ||
| decrement, | ||
| remove, | ||
| }) { | ||
| function getRestId() { |
There was a problem hiding this comment.
это вычисление нужно перенести в селекторы
koretskiyav
reviewed
Nov 2, 2021
| @@ -36,10 +36,13 @@ function Restaurants({ restaurants, loading, loaded, loadRestaurants }) { | |||
| ))} | |||
| </div> | |||
| <Switch> | |||
| <Route path="/restaurants/:restId"> | |||
| <Route path="/restaurants/:restId/menu"> | |||
There was a problem hiding this comment.
тут не нужно ничего менять, роутинга в компоненте restaurant достаточно
koretskiyav
reviewed
Nov 2, 2021
| @@ -21,6 +21,7 @@ function Basket({ title = 'Basket', total, orderProducts }) { | |||
| <h4 className={styles.title}>{title}</h4> | |||
| {orderProducts.map(({ product, amount, subtotal }) => ( | |||
| <BasketItem | |||
| restId={restId} | |||
There was a problem hiding this comment.
не нашел где это используется
There was a problem hiding this comment.
это лишнее, забыл удалить (пробовал через props restId прокинуть)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.