-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HT-5 kostenevich #71
Open
klmncr
wants to merge
2
commits into
koretskiyav:master
Choose a base branch
from
klmncr:HT-5
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
HT-5 kostenevich #71
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,13 @@ import Product from '../product'; | |
import Basket from '../basket'; | ||
|
||
import styles from './menu.module.css'; | ||
import { connect } from 'react-redux'; | ||
import { loadProducts } from '../../redux/actions'; | ||
import { | ||
productLoadedSelector, | ||
productLoadingSelector, | ||
} from '../../redux/selectors'; | ||
import Loader from '../loader'; | ||
|
||
class Menu extends Component { | ||
static propTypes = { | ||
|
@@ -13,11 +20,19 @@ class Menu extends Component { | |
|
||
state = { error: null }; | ||
|
||
componentDidMount() { | ||
if (!this.props.loading && !this.props.loaded) | ||
this.props.loadProductList(this.props.restId); | ||
} | ||
|
||
componentDidCatch(error) { | ||
this.setState({ error }); | ||
} | ||
|
||
render() { | ||
if (this.props.loading) return <Loader />; | ||
if (!this.props.loaded) return 'No data :('; | ||
|
||
const { menu } = this.props; | ||
|
||
if (this.state.error) { | ||
|
@@ -39,4 +54,14 @@ class Menu extends Component { | |
} | ||
} | ||
|
||
export default Menu; | ||
const mapStateToProps = (state, props) => ({ | ||
loading: productLoadingSelector(state, props), | ||
loaded: productLoadedSelector(state, props), | ||
restId: props.restId, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. в компонент и так прийдет пропа restId |
||
}); | ||
|
||
const mapDispatchToProps = (dispatch) => ({ | ||
loadProductList: (restId) => dispatch(loadProducts(restId)), | ||
}); | ||
|
||
export default connect(mapStateToProps, mapDispatchToProps)(Menu); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,17 +5,45 @@ import Review from './review'; | |
import ReviewForm from './review-form'; | ||
import styles from './reviews.module.css'; | ||
|
||
import { loadReviews } from '../../redux/actions'; | ||
import { loadReviews, loadUsers } from '../../redux/actions'; | ||
import { | ||
reviewLoadedSelector, | ||
reviewLoadedUsers, | ||
reviewLoadingSelector, | ||
reviewLoadingUsers, | ||
} from '../../redux/selectors'; | ||
import Loader from '../loader'; | ||
|
||
const Reviews = ({ reviews, restId, loadReviews }) => { | ||
const Reviews = ({ | ||
reviews, | ||
restId, | ||
loadReviews, | ||
loaded, | ||
loading, | ||
loadedUsers, | ||
loadingUsers, | ||
loadUsers, | ||
}) => { | ||
useEffect(() => { | ||
loadReviews(restId); | ||
}, [restId, loadReviews]); | ||
if (!loadedUsers && !loadingUsers) loadUsers(); | ||
if (!loaded && !loading) loadReviews(restId); | ||
}, [ | ||
restId, | ||
loadReviews, | ||
loadUsers, | ||
loaded, | ||
loadedUsers, | ||
loading, | ||
loadingUsers, | ||
]); | ||
|
||
if (loading || loadingUsers) return <Loader />; | ||
if (!loaded || !loadedUsers) return 'No data :('; | ||
|
||
return ( | ||
<div className={styles.reviews}> | ||
{reviews.map((id) => ( | ||
<Review key={id} id={id} /> | ||
<Review key={id} id={id} restId={restId} /> | ||
))} | ||
<ReviewForm restId={restId} /> | ||
</div> | ||
|
@@ -27,8 +55,19 @@ Reviews.propTypes = { | |
reviews: PropTypes.arrayOf(PropTypes.string.isRequired).isRequired, | ||
}; | ||
|
||
const mapDispatchToProps = { | ||
loadReviews, | ||
const mapStateToProps = (state, props) => { | ||
return { | ||
restId: props.restId, | ||
loadedUsers: reviewLoadedUsers(state), | ||
loadingUsers: reviewLoadingUsers(state), | ||
loaded: reviewLoadedSelector(state, props), | ||
loading: reviewLoadingSelector(state, props), | ||
}; | ||
}; | ||
|
||
export default connect(null, mapDispatchToProps)(Reviews); | ||
const mapDispatchToProps = (dispatch, props) => ({ | ||
loadReviews: () => dispatch(loadReviews(props.restId)), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. в компоненте идет вызов loadReviews(restId), тут можно простую форму mapDispatchToProps использовать с объектом |
||
loadUsers: () => dispatch(loadUsers()), | ||
}); | ||
|
||
export default connect(mapStateToProps, mapDispatchToProps)(Reviews); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
еще нужно обработать смену ресторана в componentDidUpdate, если убрать передачу key в Menu, то без componentDidUpdate не будут грузиться новые продукты