Ht7 #55
Open
Ht7 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koretskiyav
reviewed
Jan 22, 2021
| @@ -15,6 +16,9 @@ function BasketItem({ | |||
| decrement, | |||
| remove, | |||
| }) { | |||
| const activeCurrency = useSelector(activeCurrencySelector); | |||
There was a problem hiding this comment.
вот это все вычисление повторяется много раза и его лучше вынести в отдельный файл, я покажу на своей домашке, как это лучше делать
koretskiyav
reviewed
Jan 22, 2021
| return <Loader />; | ||
| } | ||
| if (checkOutState.loaded) { | ||
| history.push('/checkout/success'); |
There was a problem hiding this comment.
это лучше делать на уровне редакса, непосредственно при получение ответа с сервера, а не в компоненте
koretskiyav
reviewed
Jan 22, 2021
| </div> | ||
| </div> | ||
| <Link to="/checkout"> | ||
| <Button primary block> | ||
| <Button onClick={onCheckoutClickHandler} primary block> |
There was a problem hiding this comment.
в этом случае проще сделать две отдельные кнопки
koretskiyav
reviewed
Jan 22, 2021
| const [currencyName, currencyValue] = Object.entries(activeCurrency)[0]; | ||
| const history = useHistory(); | ||
| const dispatch = useDispatch(); | ||
| const checkOutState = useSelector((state) => state.checkout); |
There was a problem hiding this comment.
используйте отдельно написаные селекторы
koretskiyav
reviewed
Jan 22, 2021
| @@ -63,3 +74,25 @@ export const loadUsers = () => async (dispatch, getState) => { | |||
|
|
|||
| dispatch(_loadUsers()); | |||
| }; | |||
|
|
|||
| export const checkoutProducts = (basketItems) => async (dispatch) => { | |||
| const itemsArr = basketItems.map((basketItem) => { | |||
There was a problem hiding this comment.
тут так же можно использовать селектор
koretskiyav
reviewed
Jan 22, 2021
| ))} | ||
| <TransitionGroup> | ||
| {reviews.map((id) => ( | ||
| <CSSTransition key={id} timeout={1300} classNames={{ ...styles }}> |
There was a problem hiding this comment.
сюда лучше не передавать лишние стили, которые не касаются анимации (либо отдельный файл сделать, либо из объекта стилей отобрать нужное)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HT7 ready
!!!currency implements via redux but not context,
TODO
animation should be added.