HT7 #54
Open
HT7 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r disabling buttons
koretskiyav
reviewed
Jan 22, 2021
|
|
||
| const mapStateToProps = state => ({ | ||
| sending: orderSendingSelector(state), | ||
| pathname: state.router.location.pathname, |
There was a problem hiding this comment.
используйте селекторы, в т.ч. в connected-react-router есть свои селекторы, которые можно так же использовать
koretskiyav
reviewed
Jan 22, 2021
| <CSSTransition | ||
| key={id} | ||
| timeout={500} | ||
| classNames={{ ...styles }} |
There was a problem hiding this comment.
сюда лучше не передавать лишние стили, которые не касаются анимации (либо отдельный файл сделать, либо из объекта стилей отобрать нужное)
koretskiyav
reviewed
Jan 22, 2021
|
|
||
| return <Route path="/restaurants/:restId" component={Restaurants} />; | ||
| return ( | ||
| <Switch> |
There was a problem hiding this comment.
отличное решение, у меня не так красиво :(
koretskiyav
reviewed
Jan 22, 2021
| '/api/order', | ||
| { | ||
| method: 'POST', | ||
| headers: { |
There was a problem hiding this comment.
вот эти все низкоуровневые штуки лучше делать в middleware/api.js, на занятие расскажу почему
|
отличная работа! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.