Ht6 #53
Open
Ht6 #53
+64
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s . Переход просто по урлу. не придумала где добавить переход в интерфейсе.
koretskiyav
reviewed
Jan 19, 2021
| @@ -28,6 +28,18 @@ export const restaurantsListSelector = createSelector( | |||
| Object.values | |||
| ); | |||
|
|
|||
| export const restaurantIdByProductIdSelector = (state, props) => | |||
| Object.values(restaurantsSelector(state)).find((rest) => | |||
There was a problem hiding this comment.
вот это сложное вычисление будет вызываться для каждого элемента в корзине, можно сделать немного лучше - изначальны вычислить соотношение этих id, а потом в этой мапе уже их брать
There was a problem hiding this comment.
"Изначально вычислить" немного не поняла. Вычислить ид ресторана где-то выше по родителям и прокинуть в basket item пропсом?
… HT6 # Conflicts: # README.md # src/components/basket/basket-item/basket-item.js # src/pages/restaurants-page.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.