HT5 done #46
Open
HT5 done #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koretskiyav
reviewed
Jan 15, 2021
| } catch (error) { | ||
| dispatch({ type: LOAD_REVIEWS + FAILURE, error }); | ||
| } | ||
| }; | ||
| export const loadProducts = (restaurantId) => async (dispatch) => { |
There was a problem hiding this comment.
продукты нужно было загрузить через api middleware
koretskiyav
reviewed
Jan 15, 2021
| const { id, name, menu, reviews } = restaurant; | ||
| useEffect(() => { | ||
| const allProdArray = Object.keys(allProducts); |
There was a problem hiding this comment.
я в своей домашке покажу, как это можно сделать немного красивее
koretskiyav
reviewed
Jan 15, 2021
| reviews.includes(reviewId) | ||
| ); | ||
|
|
||
| //todo fix loop |
There was a problem hiding this comment.
лучше это сразу попровлять в селекторе averageRatingSelector
koretskiyav
reviewed
Jan 15, 2021
| <Rate value={rating} /> | ||
| const Review = ({ id }) => { | ||
| const allUsers = useSelector((state) => usersSelector(state)); | ||
| const allReviews = useSelector((state) => state.reviews.entities); |
There was a problem hiding this comment.
не забываем использовать селекторы
koretskiyav
reviewed
Jan 15, 2021
| loadUsers, | ||
| }) => { | ||
| useEffect(() => { | ||
| loadUsers(); |
There was a problem hiding this comment.
тут все равно нужно проверку делать на loading, т.к. этот компонент может быть размонтирован и смонтирован повторно
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.