HT4 #42
Open
HT4 #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koretskiyav
reviewed
Jan 12, 2021
| }; | ||
|
|
||
| export default Restaurant; | ||
| export default connect((state, ownProps) => ({ | ||
| name: state.restaurants[ownProps.id].name, |
There was a problem hiding this comment.
это нужно выносить в селекторы
koretskiyav
reviewed
Jan 12, 2021
| const tabs = restaurants.map((restaurant) => ({ | ||
| title: restaurant.name, | ||
| content: <Restaurant restaurant={restaurant} />, | ||
| const tabs = Object.keys(restaurants).map((id) => ({ |
There was a problem hiding this comment.
Object.keys(restaurants) должно быть в селекторах и мемоизировано
koretskiyav
reviewed
Jan 12, 2021
| Review.defaultProps = { | ||
| user: 'Anonymous', | ||
| const mapStateToProps = (state, ownProps) => { | ||
| const review = state.reviews[ownProps.id]; |
There was a problem hiding this comment.
это все тоже нужно переносить в селекторы
koretskiyav
reviewed
Jan 12, 2021
| const userId = uuidv4(); | ||
| const reviewId = uuidv4(); | ||
|
|
||
| action.payload = { |
There was a problem hiding this comment.
не стоит мутировать action, лучше создать новый
koretskiyav
reviewed
Jan 12, 2021
|
|
||
| export const averageRatingSelector = (state, props) => | ||
| createSelector(reviewSelector, (reviews) => { | ||
| const restaurantReviews = state.restaurants[props.id].reviews; |
There was a problem hiding this comment.
лучше не делать одновременно и обычный селектор и createSelector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.