HT4 #41
Open
HT4 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
January 8, 2021 22:11
(should create and add users id)
koretskiyav
reviewed
Jan 12, 2021
| @@ -50,8 +51,8 @@ Product.propTypes = { | |||
| }; | |||
|
|
|||
| const mapStateToProps = (state, ownProps) => ({ | |||
| amount: state.order[ownProps.id] || 0, | |||
| product: state.products[ownProps.id], | |||
| amount: orderSelector(state)[ownProps.id] || 0, | |||
There was a problem hiding this comment.
лучше сразу делать селекторы, которые принимаю и стейт и пропы - orderSelector(state, ownProps) чтобы менять потом в компоненте при изменении структуры данных
koretskiyav
reviewed
Jan 12, 2021
|
|
||
| const averageRating = useMemo(() => { | ||
| const total = reviews.reduce((acc, { rating }) => acc + rating, 0); | ||
| const total = reviews.reduce( |
There was a problem hiding this comment.
это лучше перенести в селекторы
koretskiyav
reviewed
Jan 12, 2021
|
|
||
| const Restaurants = ({ restaurants }) => { | ||
| const tabs = restaurants.map((restaurant) => ({ | ||
| const tabs = Object.values(restaurants).map((restaurant) => ({ |
There was a problem hiding this comment.
Object. values(restaurants) должно быть в селекторах и мемоизировано
koretskiyav
reviewed
Jan 12, 2021
| }; | ||
|
|
||
| const mapStateToProps = (state, ownProps) => { | ||
| const review = reviewsSelector(state)[ownProps.id]; |
There was a problem hiding this comment.
все эти вычисления нужно выносить в селекторы, чтобы компонент занимался только рендером
koretskiyav
reviewed
Jan 12, 2021
| const newReviewId = uuidv4(); | ||
| const newUserId = uuidv4(); | ||
|
|
||
| action.payload.values = { |
There was a problem hiding this comment.
не стоит мутировать action, лучше создать новый
koretskiyav
reviewed
Jan 12, 2021
| ...restaurants, | ||
| [activeRestaurantId]: { | ||
| ...activeRestaurantData, | ||
| ...activeRestaurantData.reviews.push(addedNewReview), |
There was a problem hiding this comment.
это все равно мутация reviews по ссылке, такого делать нельзя
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.