Ht3 #34
Open
Ht3 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koretskiyav
reviewed
Jan 5, 2021
src/redux/reducers/order.js
Outdated
| const { type, payload } = action; | ||
| switch (type) { | ||
| case INCREMENT: | ||
| return { ...state, [payload.id]: (state[payload.id] || 0) + 1 }; | ||
| case DECREMENT: | ||
| return { ...state, [payload.id]: (state[payload.id] || 0) - 1 }; | ||
| case CLEAR: |
There was a problem hiding this comment.
тут нужно было удалять только один конкретный продукт, а не все, что есть в корзине
koretskiyav
reviewed
Jan 5, 2021
src/components/basket/basket.js
Outdated
| hideBasket, | ||
| openBasket, | ||
| }) => { | ||
| const products = useMemo(() => { |
koretskiyav
reviewed
Jan 5, 2021
src/components/basket/basket.js
Outdated
| decrement: (productId) => dispatch(decrement(productId)), | ||
| }); | ||
|
|
||
| export default connect(mapStateToProps, mapDispatchToProps)(popup(Basket)); |
There was a problem hiding this comment.
тут лучше просто usePopup использовать в компоненте - намного очевиднее будет
koretskiyav
reviewed
Jan 5, 2021
src/components/basket/basket.js
Outdated
| </button> | ||
| {isOpenBasket && ( | ||
| <div className={styles.products}> | ||
| {products.map((product) => ( |
There was a problem hiding this comment.
на сколько я понимаю тут всегда показываются все продукты, даже те, которые мы не заказывали?
… HT3 # Conflicts: # src/components/app/app.js # src/components/basket/basket.js # src/components/basket/basket.module.css # src/redux/actions.js # src/redux/constants.js # src/redux/reducers/order.js
…into HT3 # Conflicts: # src/components/basket/basket.js # src/components/basket/basket.module.css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.